linux-kernel - Re: [PATCH v2 08/13] KVM: implement multiple address spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55765B68.1010300@linux.intel.com>
Date:	Tue, 09 Jun 2015 11:20:08 +0800
From:	Xiao Guangrong <guangrong.xiao@...ux.intel.com>
To:	Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org
CC:	rkrcmar@...hat.com, bdas@...hat.com
Subject: Re: [PATCH v2 08/13] KVM: implement multiple address spaces



On 05/28/2015 01:05 AM, Paolo Bonzini wrote:

>   	/*
> @@ -772,6 +776,7 @@ int __kvm_set_memory_region(struct kvm *kvm,
>   	struct kvm_memory_slot *slot;
>   	struct kvm_memory_slot old, new;
>   	struct kvm_memslots *slots = NULL, *old_memslots;
> +	int as_id, id;
>   	enum kvm_mr_change change;
>
>   	r = check_memory_region_flags(mem);
> @@ -779,24 +784,27 @@ int __kvm_set_memory_region(struct kvm *kvm,
>   		goto out;
>
>   	r = -EINVAL;
> +	as_id = mem->slot >> 16;
> +	id = mem->slot & 65535;
> +

A minor comment, Could you put these decoding into a separate function?

Nice idea indeed.

Reviewed-by: Xiao Guangrong <guangrong.xiao@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/