linux-kernel - Re: [PATCH v2 4/8] input: goodix: reset device at init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433865182.5707.7.camel@hadess.net>
Date:	Tue, 09 Jun 2015 17:53:02 +0200
From:	Bastien Nocera <hadess@...ess.net>
To:	Irina Tirdea <irina.tirdea@...el.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Mark Rutland <mark.rutland@....com>,
	linux-input@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Octavian Purdila <octavian.purdila@...el.com>
Subject: Re: [PATCH v2 4/8] input: goodix: reset device at init

On Tue, 2015-06-09 at 17:34 +0200, Bastien Nocera wrote:
> On Mon, 2015-06-08 at 17:37 +0300, Irina Tirdea wrote:
> > After power on, it is recommended that the driver resets the 
> > device.
> > The reset procedure timing is described in the datasheet and is 
> > used
> > at device init (before writing device configuration) and
> > for power management. It is a sequence of setting the interrupt
> > and reset pins high/low at specific timing intervals. This 
> > procedure
> > also includes setting the slave address to the one specified in the
> > ACPI/device tree.
> 
> This breaks the touchscreen on my Onda v975w:
> [  239.732858] Goodix-TS i2c-GDIX1001:00: ID 9271, version: 1020
> [  239.732977] Goodix-TS i2c-GDIX1001:00: Failed to get reset GPIO: 
> -16
> [  239.736071] Goodix-TS: probe of i2c-GDIX1001:00 failed with error 
> -16
> 
> This is the DSDT for that device:
> https://bugzilla.kernel.org/attachment.cgi?id=149331

(Note that this means that I haven't been able to test any following
patches in that series than 4/8).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/