linux-kernel - Re: [PATCH v5 3/6] i2c: at91: update documentation for DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55770EA6.8020908@atmel.com>
Date:	Tue, 9 Jun 2015 18:04:54 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Cyrille Pitchen <cyrille.pitchen@...el.com>,
	<ludovic.desroches@...el.com>, <linux-i2c@...r.kernel.org>,
	<wsa@...-dreams.de>
CC:	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<devicetree@...r.kernel.org>, <pawel.moll@....com>,
	<mark.rutland@....com>, <ijc+devicetree@...lion.org.uk>,
	<galak@...eaurora.org>, <robh+dt@...nel.org>
Subject: Re: [PATCH v5 3/6] i2c: at91: update documentation for DT bindings

Le 03/06/2015 18:25, Cyrille Pitchen a écrit :
> add a new value "atmel,at91sama5d2-i2c" for the "compatible" property.

Well, here I would like "atmel,sama5d2-i2c" like any other "SAMA5"
product compatibility string out there...

Aka NAK for me ;-)


> add a new optional property "atmel,fifo-size" to enable FIFO support when
> available.
> add missing optional properties "dmas" and "dma-names".
> 
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@...el.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-at91.txt | 29 ++++++++++++++++++++--
>  1 file changed, 27 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
> index 388f0a2..7c04fd9 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-at91.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
> @@ -2,8 +2,8 @@ I2C for Atmel platforms
>  
>  Required properties :
>  - compatible : Must be "atmel,at91rm9200-i2c", "atmel,at91sam9261-i2c",
> -     "atmel,at91sam9260-i2c", "atmel,at91sam9g20-i2c", "atmel,at91sam9g10-i2c"
> -     or "atmel,at91sam9x5-i2c"
> +     "atmel,at91sam9260-i2c", "atmel,at91sam9g20-i2c", "atmel,at91sam9g10-i2c",
> +     "atmel,at91sam9x5-i2c" or "atmel,at91sama5d2-i2c"

Ditto

>  - reg: physical base address of the controller and length of memory mapped
>       region.
>  - interrupts: interrupt number to the cpu.
> @@ -13,6 +13,9 @@ Required properties :
>  
>  Optional properties:
>  - clock-frequency: Desired I2C bus frequency in Hz, otherwise defaults to 100000
> +- dmas: A list of two dma specifiers, one for each entry in dma-names.
> +- dma-names: should contain "tx" and "rx".
> +- atmel,fifo-size: size of the RX and TX FIFOs, if available.
>  - Child nodes conforming to i2c bus binding
>  
>  Examples :
> @@ -32,3 +35,25 @@ i2c0: i2c@...84000 {
>  		pagesize = <128>;
>  	}
>  }
> +
> +i2c0: i2c@...34600 {
> +	compatible = "atmel,at91sama5d2-i2c";

Ditto

> +	reg = <0xf8034600 0x100>;
> +	interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
> +	dmas = <&dma0
> +		(AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1))
> +		AT91_XDMAC_DT_PERID(11)>,
> +	       <&dma0
> +		(AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1))
> +		AT91_XDMAC_DT_PERID(12)>;
> +	dma-names = "tx", "rx";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	clocks = <&flx0>;
> +	atmel,fifo-size = <32>;
> +
> +	wm8731: wm8731@1a {
> +		compatible = "wm8731";
> +		reg = <0x1a>;
> +	};
> +};
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/