| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Jun 2015 09:32:59 -0700 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Pavel Machek <pavel@....cz> Cc: Samuel Thibault <samuel.thibault@...-lyon.org>, Pali Rohár <pali.rohar@...il.com>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, rpurdie@...ys.net, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: Re: [PATCH 0/3] Switch input leds over to standard LED class devices Hi Pavel, On Tue, Jun 09, 2015 at 06:18:18PM +0200, Pavel Machek wrote: > Hi! > > > > I finally was able to spend some time looking over Samuel's patch set > > > switching input LEDs from custom implementation over to standard LED class > > > devices and I think this is the shape I am reasonably happy with. The > > > changes: > > > > Thanks! > > > > > Please take a look and see if you see any holes. > > > > Tested on thinkpad t40p. Started X, but then I went to text console > > for testing. > > > > 1) input4::caps-lock -- default trigger was not set, so caps lock did > > not control the LED. That's bug, right? > > max_brightness for caps-lock led is 255. I believe that should be 1, > as keyboard LEDs can not do PWM. Yes, you are right, I'll change max_brightness to 1 in the next revision. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists