linux-kernel - Re: [PATCH v5 1/2] ASoC: qcom: document apq8016 sbc machine driver bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150609171313.GK14071@sirena.org.uk>
Date:	Tue, 9 Jun 2015 18:13:13 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	alsa-devel@...a-project.org, Rob Herring <robh+dt@...nel.org>,
	Patrick Lai <plai@...eaurora.org>,
	Banajit Goswami <bgoswami@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	kwestfie@...eaurora.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v5 1/2] ASoC: qcom: document apq8016 sbc machine driver
 bindings

On Tue, Jun 09, 2015 at 06:08:24PM +0100, Srinivas Kandagatla wrote:

> >>>+- external	: flag to indicate if the I2S is connected to external codec

> >not sure I understand why we need a boolean property indicating if an
> >external CODEC is in use - what is the consequence of setting this
> >property?

> As of today, the consequence of setting this flag is to setup correct
> dai_link names.
> Also there are some limitations on which MI2S can be configured to external
> or internal codecs, this flag can be used in future to validate such
> configurations, if required.

That validation sounds like something that the SoC drivers should be
doing if required rather than the machine driver - otherwise every
machine driver using this SoC would have to implement the same
validation.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)