linux-kernel - Re: [PATCH v5 2/2] ASoC: qcom: add apq8016 sound card support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150609180435.GV14071@sirena.org.uk>
Date:	Tue, 9 Jun 2015 19:04:35 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	alsa-devel@...a-project.org, Rob Herring <robh+dt@...nel.org>,
	Patrick Lai <plai@...eaurora.org>,
	Banajit Goswami <bgoswami@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	kwestfie@...eaurora.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v5 2/2] ASoC: qcom: add apq8016 sound card support

On Tue, Jun 09, 2015 at 06:51:59PM +0100, Srinivas Kandagatla wrote:
> On 09/06/15 18:07, Mark Brown wrote:

> >Why not just do these one time at probe, we don't undo them when we shut
> >the DAI down?

> If I do that Am afraid that the driver would loose the flexibility of
> selecting different MI2S from DT level. Hardcoding which MI2S can got to
> external or internal codec is something that I wanted to avoid from the
> start.

I don't understand why we'd loose anything - we get init() callbacks on
the DAIs when they're instantiated?

> I will add the shutdown code to reset the configuration.

OK.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)