linux-kernel - Re: [PATCH V2] regulator: core: fix constraints debug output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Jun 2015 20:49:14 +0200 (CEST)
From:	Stefan Wahren <stefan.wahren@...e.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Joe Perches <joe@...ches.com>, Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH V2] regulator: core: fix constraints debug output


> Mark Brown <broonie@...nel.org> hat am 9. Juni 2015 um 20:00 geschrieben:
>
>
> On Wed, Jun 03, 2015 at 09:56:29PM +0000, Stefan Wahren wrote:
> > The line buffer for constraints debug isn't big enough to hold the output
> > in all cases. So fix the possible buffer overflow by the usage of the
> > scnprintf().
>
> If we know how much output we might produce then why not extend the
> buffer so we don't need to cut it off? The defensive programming is
> good but that seems a better fix.
 
I thought the intension was to keep the output in "one" line. If not i suggest
to increase the size to 160 bytes, which is sufficient for all cases.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/