lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Jun 2015 21:18:04 +0200 From: Denys Vlasenko <dvlasenk@...hat.com> To: Andy Lutomirski <luto@...capital.net> CC: Ingo Molnar <mingo@...nel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Steven Rostedt <rostedt@...dmis.org>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, Oleg Nesterov <oleg@...hat.com>, Frederic Weisbecker <fweisbec@...il.com>, Alexei Starovoitov <ast@...mgrid.com>, Will Drewry <wad@...omium.org>, Kees Cook <keescook@...omium.org>, X86 ML <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 4/5] x86/asm/entry/32: Replace RESTORE_RSI_RDI[_RDX] with open-coded 32-bit reads On 06/09/2015 09:11 PM, Andy Lutomirski wrote: > On Tue, Jun 9, 2015 at 12:03 PM, Denys Vlasenko <dvlasenk@...hat.com> wrote: >> On 06/09/2015 09:01 PM, Andy Lutomirski wrote: >>> On Tue, Jun 9, 2015 at 11:54 AM, Denys Vlasenko <dvlasenk@...hat.com> wrote: >>>> This doesn't change much, but this uses shorter 32-bit insns: >>>> >>>> -48 8b 74 24 68 mov 0x68(%rsp),%rsi >>>> -48 8b 7c 24 70 mov 0x70(%rsp),%rdi >>>> -48 8b 54 24 60 mov 0x60(%rsp),%rdx >>>> +8b 74 24 68 mov 0x68(%rsp),%esi >>>> +8b 7c 24 70 mov 0x70(%rsp),%edi >>>> +8b 54 24 60 mov 0x60(%rsp),%edx >>>> >>>> Since these are the only uses of RESTORE_RSI_RDI[_RDX], drop these macros. >>>> >>> >>> It probably doesn't matter for these fast paths, but, for the full >>> slow path return, we really do need to restore the full pt_regs. >>> After all, the syscall we're returning from might be sigreturn. >> >> This is compat 32-bit syscall handling code. >> IIUC we do not restore high half of any registers for 32-bit tasks. >> >> Am I missing something? > > Yes -- 64-bit tasks can call 32-bit compat syscalls. Not via SYSCALL and SYSENTER code paths. This patch touches only those code paths. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists