linux-kernel - Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <557667AC.3030506@toradex.com>
Date:	Tue, 9 Jun 2015 09:42:28 +0530
From:	Bhuvanchandra DV <bhuvanchandra.dv@...adex.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	<gregkh@...uxfoundation.org>, <devicetree@...r.kernel.org>,
	<linux-serial@...r.kernel.org>, <moorray3@...pl>,
	<linux-kernel@...r.kernel.org>, <stefan@...er.ch>,
	<bhuvanchandra.dv@...il.com>, <kernel@...gutronix.de>,
	<shawn.guo@...aro.org>, <jslaby@...e.cz>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control
 from set/get_mctrl

On 06/08/2015 02:42 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote:
>> +    /*
>> +     * CTS/RTS can _only_ be handled
>> +     * automatically by the hardware.
>> +     */
>
> That's really not acceptable.  You need to do something here so that you
> can _force_ RTS to be deasserted when the kernel buffers fill up - be
> that by stopping reading characters and letting the FIFO fill up or
> something of that ilk.
Agreed, will fix this.
>
> Ignoring the rest of the flow control system in the kernel is not really
> acceptable.
>

Best regards,
Bhuvan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/