linux-kernel - Re: [PATCHv3] perf stat: Add id into perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150609200922.GA7884@krava.redhat.com>
Date:	Tue, 9 Jun 2015 22:09:23 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	David Ahern <dsahern@...il.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCHv3] perf stat: Add id into perf_stat struct

On Mon, Jun 08, 2015 at 11:03:40AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jun 04, 2015 at 03:50:55PM +0200, Jiri Olsa escreveu:
> > On Wed, Jun 03, 2015 at 04:25:51PM +0200, Jiri Olsa wrote:
> > > We need fast way to identify evsel as transaction event
> > > for shadow counters computation. Currently we are using
> > > possition (in evlist) based way.
> > > 
> > > Adding 'id' into 'struct perf_stat' so it can carry transaction
> > > event ID and we can use it for shadow counters computations.
> > > 
> > > Link: http://lkml.kernel.org/n/tip-9lnvjksibrs0flhkpix2qkm9@git.kernel.org
> > > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > > ---
> > 
> > using perf_evsel__name instead of evsel->name pointer
> 
> It now passes 'perf test' on rhel7/fedora21 systems, but it fails on a
> rhel6 system, I applied it, will test it further on the rhel6 system to
> see what went wrong there, unless you do it first ;-)
> 
> [root@...dy ~]# perf test 15
> 15: struct perf_event_attr setup                             :sh: line
> 1:  5381 Aborted                 (core dumped)
> PERF_TEST_ATTR=/tmp/tmp8ZBLwc /home/acme/bin/perf stat -o
> /tmp/tmp8ZBLwc/perf.data --group -e cycles,instructions kill > /dev/null
> 2>&1
> sh: line 1:  5438 Aborted                 (core dumped)
> PERF_TEST_ATTR=/tmp/tmpnRDADB /home/acme/bin/perf stat -o
> /tmp/tmpnRDADB/perf.data -e '{cycles,instructions}' kill > /dev/null
> 2>&1
>  Ok
> [root@...dy ~]# uname -r
> 2.6.32-504.8.1.el6.x86_64
> [root@...dy ~]# cat /etc/redhat-release 
> Red Hat Enterprise Linux Server release 6.6 (Santiago)
> [root@...dy ~]# 

hum, cant reproduce

[root@...-x3650m4-02 perf]# ./perf test 15
15: struct perf_event_attr setup                             : Ok


the server is latest rhel6 kernel (scratch):

[root@...-x3650m4-02 perf]# uname -a
Linux ibm-x3650m4-02.lab.eng.brq.redhat.com 2.6.32-556.el6perf_ivb_haswell_1.x86_64 #1 SMP Wed Apr 29 06:00:24 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
[root@...-x3650m4-02 perf]# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 6.6 (Santiago)


jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/