linux-kernel - Re: [PATCH v2 6/8] drivers/md/md.c: Use strreplace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150610071706.58ddc72e@home.neil.brown.name>
Date:	Wed, 10 Jun 2015 07:17:06 +1000
From:	Neil Brown <neilb@...e.de>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Joe Perches <joe@...ches.com>,
	Al Viro <viro@...IV.linux.org.uk>, linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/8] drivers/md/md.c: Use strreplace

On Tue,  9 Jun 2015 01:26:54 +0200
Rasmus Villemoes <linux@...musvillemoes.dk> wrote:

> There's no point in starting over when we meet a '/'. This also
> eliminates a stack variable and a little .text.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
> v2: no changes.
> 
>  drivers/md/md.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 27506302eb7a..2ea2f28551c5 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -2024,7 +2024,6 @@ static int bind_rdev_to_array(struct md_rdev
> *rdev, struct mddev *mddev) {
>  	char b[BDEVNAME_SIZE];
>  	struct kobject *ko;
> -	char *s;
>  	int err;
>  
>  	/* prevent duplicates */
> @@ -2070,8 +2069,7 @@ static int bind_rdev_to_array(struct md_rdev
> *rdev, struct mddev *mddev) return -EBUSY;
>  	}
>  	bdevname(rdev->bdev,b);
> -	while ( (s=strchr(b, '/')) != NULL)
> -		*s = '!';
> +	strreplace(b, '/', '!');
>  
>  	rdev->mddev = mddev;
>  	printk(KERN_INFO "md: bind<%s>\n", b);


Acked-by: NeilBrown <neilb@...e.de>

I'm happy for Andrew to merge this.
Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/