linux-kernel - Re: [PATCH v5 4/6] i2c: at91: add support for new alternative command mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150609221936.GB1717@katana>
Date:	Wed, 10 Jun 2015 07:19:37 +0900
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Cyrille Pitchen <cyrille.pitchen@...el.com>,
	ludovic.desroches@...el.com, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, robh+dt@...nel.org
Subject: Re: [PATCH v5 4/6] i2c: at91: add support for new alternative
 command mode

Nicolas,

> > +static struct at91_twi_pdata at91sama5d2_config = {
> 
> No, please name it:
> 
> "sama5d2_config"

Thanks for your input, but please don't quote the whole mail for those
tiny comments. Only the relevant parts, please. Otherwise it is too easy
to miss things.

Thanks,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)