linux-kernel - Re: [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Jun 2015 15:27:09 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	"hch@....de" <hch@....de>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"neilb@...e.de" <neilb@...e.de>,
	"jmoyer@...hat.com" <jmoyer@...hat.com>,
	"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
	"axboe@...nel.dk" <axboe@...nel.dk>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"rafael@...nel.org" <rafael@...nel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm
 infrastructure and NFIT support

On Mon, Jun 8, 2015 at 11:33 PM, hch@....de <hch@....de> wrote:
> On Wed, Jun 03, 2015 at 07:24:34PM +0000, Williams, Dan J wrote:
>> > > +static inline struct acpi_nfit_memory_map *__to_nfit_memdev(struct nfit_mem *nfit_mem)
>> >
>> > This line is over 80 characters.
>>
>> I generally don't see the point of fixing up occasional small incursions
>> over 80 characters if it makes the code more amenable to grep.
>
> Just use shorter type names or add a line break before the symbol
> names.  Too long lines are highly annoying.

Note that "acpi_nfit_memory_map" is the identifier chosen by ACPICA,
I'm just a consumer.  That said I've gone and done a 80 column cleanup
across all the patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/