linux-kernel - Re: [PATCH v3] powerpc/cache: add cache flush operation for various e500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1433888900.2477.104.camel@freescale.com>
Date:	Tue, 9 Jun 2015 17:28:20 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	<Yuantian.Tang@...escale.com>
CC:	<b07421@...escale.com>, <linuxppc-dev@...ts.ozlabs.org>,
	<linux-kernel@...r.kernel.org>,
	Chenhui Zhao <chenhui.zhao@...escale.com>,
	Tang Yuantian <Yuantian.Tang@...scale.com>
Subject: Re: [PATCH v3] powerpc/cache: add cache flush operation for various
 e500

On Tue, 2015-06-09 at 09:53 +0800, Yuantian.Tang@...escale.com wrote:
> From: Tang Yuantian <Yuantian.Tang@...escale.com>
> 
> Various e500 core have different cache architecture, so they
> need different cache flush operations. Therefore, add a callback
> function cpu_flush_caches to the struct cpu_spec. The cache flush
> operation for the specific kind of e500 is selected at init time.
> The callback function will flush all caches inside the current cpu.
> 
> Signed-off-by: Chenhui Zhao <chenhui.zhao@...escale.com>
> Signed-off-by: Tang Yuantian <Yuantian.Tang@...scale.com>
> ---
> v3:
>       - change all flush_caches to cpu_down_flush
>       - replace whitespace with tab
[snip]
                .cpu_setup              = __setup_cpu_e500v2,
>               .machine_check          = machine_check_e500,
>               .platform               = "ppc8548",
> +             .cpu_down_flush = cpu_down_flush_e500v2,

It's still not lined up.  I'm not a fan of the "line up all the =" 
style, as it's a pain to maintain (and can be harder to read if the "=" 
is too far to the right), but mixing the two is worse.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/