linux-kernel - Re: [PATCH 3/6] clk: keystone: make use of of_clk_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2015 15:14:27 -0700
From:	santosh shilimkar <santosh.shilimkar@...cle.com>
To:	dinguyen@...nsource.altera.com, sboyd@...eaurora.org,
	mturquette@...aro.org
CC:	dinh.linux@...il.com, linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Santosh Shilimkar <ssantosh@...nel.org>
Subject: Re: [PATCH 3/6] clk: keystone: make use of of_clk_parent_fill helper
 function

On 6/10/2015 2:49 PM, dinguyen@...nsource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@...nsource.altera.com>
>
> Use of_clk_parent_fill to fill in the parent clock names' array.
>
> Signed-off-by: Dinh Nguyen <dinguyen@...nsource.altera.com>
> Cc: Santosh Shilimkar <ssantosh@...nel.org>
> ---
>   drivers/clk/keystone/pll.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
Looks fine by me.
Acked-by: Santosh Shilimkar <ssantosh@...nel.org>


> diff --git a/drivers/clk/keystone/pll.c b/drivers/clk/keystone/pll.c
> index 0dd8a4b..d885372 100644
> --- a/drivers/clk/keystone/pll.c
> +++ b/drivers/clk/keystone/pll.c
> @@ -293,8 +293,7 @@ static void __init of_pll_mux_clk_init(struct device_node *node)
>   		return;
>   	}
>
> -	parents[0] = of_clk_get_parent_name(node, 0);
> -	parents[1] = of_clk_get_parent_name(node, 1);
> +	of_clk_parent_fill(node, parents, 2);
>   	if (!parents[0] || !parents[1]) {
>   		pr_err("%s: missing parent clocks\n", __func__);
>   		return;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/