linux-kernel - Re: [PATCH] x86/asm/entry/32, selftests: Add test_syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150610183656.6adeedb6@gandalf.local.home>
Date:	Wed, 10 Jun 2015 18:36:56 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	Kees Cook <keescook@...omium.org>,
	"CC: Ingo Molnar" <mingo@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andy Lutomirski <luto@...capital.net>,
	Oleg Nesterov <oleg@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Will Drewry <wad@...omium.org>,
	"x86@...nel.org" <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] x86/asm/entry/32, selftests: Add test_syscall_vdso test

On Wed, 10 Jun 2015 22:15:58 +0200
Denys Vlasenko <dvlasenk@...hat.com> wrote:

> On 06/10/2015 10:00 PM, Kees Cook wrote:
> >> +       printf("[SKIP]\tAT_SYSINFO not supplied, can't test\n");
> >> +       exit(0); /* this is not a test failure */
> > 
> > Why is that not a test failure? It would mean it didn't actually test
> > anything, which seems like a failure to me.
> 
> Are you objecting to comment wording, or to exiting with 0?
> 
> I exit with 0 because no bug was detected.

I believe there's a way to exit with "not supported". That's what the
ftrace tests do.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/