linux-kernel - Re: [PATCH] added device tree support to gpio-generic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbWhtkMgz2qTg1y7AguLQCJXnAoi7gVnFvPb1sR7eES_g@mail.gmail.com>
Date:	Wed, 10 Jun 2015 10:42:42 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Romain Baeriswyl <romain.baeriswyl@...tech.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Christian Ruppert <christian.ruppert@...tech.com>,
	Anton Vorontsov <cbouatmailru@...il.com>,
	Rojhalat Ibrahim <imr@...chenk.de>,
	abdoulaye berthe <berthe.ab@...il.com>,
	Anthony Fee <anthony.fee@...tex.com>,
	Alexander Shiyan <shc_work@...l.ru>
Subject: Re: [PATCH] added device tree support to gpio-generic driver

This patch needs to go to the devicetree list too, see To: on this
mail.

On Fri, Jun 5, 2015 at 8:51 AM, Romain Baeriswyl
<romain.baeriswyl@...tech.com> wrote:

> +Required properties:
> +- compatible : "basic-mmio-gpio" for little endian register access or
> +               "basic-mmio-gpio-be" for big endian register access

Basic I don't know.

"single-register-gpio" is more to the point, don't you think?

> +- ngpios: Specifies the number of gpio mapped in the register. The value is
> +          limited to the number of bits of the LONG type.

So if it is 8 for a 32 bit register, does it mean bits 0..7 little endian or
big endian, or does it depend on endianness? Clarify this
in the binding.

> +
> +Optional properties:
> +- base: Allows to forces the gpio number base offset used to index the gpio in
> +        the device. If it is not see then the driver search autonoumously for
> +        valid index range.
> +
> +Examples:
> +
> +       gpio_a {
> +               compatible = "basic-mmio-gpio";
> +               ngpios = <32>;
> +       };

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/