linux-kernel - Re: [PATCH] Input: goodix - do not explicitly set evbits in input device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2015 12:18:10 +0200
From:	Bastien Nocera <hadess@...ess.net>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Irina Tirdea <irina.tirdea@...el.com>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: goodix - do not explicitly set evbits in input
 device

On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote:
> input_mt_init_slots() will do that for us.

I'm guessing you know what you're doing here, but I couldn't find where
the EV_SYN bit would have been set in the input_mt_init_slots() call
chain.

> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  drivers/input/touchscreen/goodix.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/goodix.c 
> b/drivers/input/touchscreen/goodix.c
> index 73ade35..b4d12e2 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -301,10 +301,6 @@ static int goodix_request_input_dev(struct 
> goodix_ts_data *ts, u16 version,
>               return -ENOMEM;
>       }
>  
> -     ts->input_dev->evbit[0] = BIT_MASK(EV_SYN) |
> -                               BIT_MASK(EV_KEY) |
> -                               BIT_MASK(EV_ABS);
> -
>       input_set_abs_params(ts->input_dev, ABS_MT_POSITION_X,
>                            0, ts->abs_x_max, 0, 0);
>       input_set_abs_params(ts->input_dev, ABS_MT_POSITION_Y,
> -- 
> 2.2.0.rc0.207.ga3a616c
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/