linux-kernel - Re: [PATCH 09/15] mfd: kill off set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZkDbuAgMmpHaKVSD_cwo1ykV4jFsMUJOb3E=emRrzYXw@mail.gmail.com>
Date:	Wed, 10 Jun 2015 14:43:54 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Rob Herring <robh@...nel.org>
Cc:	Russell King <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arm@...nel.org" <arm@...nel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>, Milo Kim <milo.kim@...com>,
	Kumar Gala <galak@...eaurora.org>,
	Andy Gross <agross@...eaurora.org>,
	David Brown <davidb@...eaurora.org>,
	Tony Lindgren <tony@...mide.com>,
	patches@...nsource.wolfsonmicro.com,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	linux-soc@...r.kernel.org, Linux-OMAP <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 09/15] mfd: kill off set_irq_flags usage

On Tue, Jun 9, 2015 at 8:26 PM, Rob Herring <robh@...nel.org> wrote:

> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
>
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROBE -> !IRQ_NOPROBE
> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
>
> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> and setting IRQ_NOREQUEST already, so there is no need to do this in
> .map() functions and we can simply remove the set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> copy and paste of this code.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Milo Kim <milo.kim@...com>
> Cc: Kumar Gala <galak@...eaurora.org>
> Cc: Andy Gross <agross@...eaurora.org>
> Cc: David Brown <davidb@...eaurora.org>
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: patches@...nsource.wolfsonmicro.com
> Cc: linux-arm-msm@...r.kernel.org
> Cc: linux-soc@...r.kernel.org
> Cc: linux-omap@...r.kernel.org

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/