linux-kernel - Re: [PATCH v2 04/10] Documentation/kdbus: use parentheses uniformly in KDBUS_ITEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANq1E4Sf9pOavqO_qJwfWGgVtX_jk24j7FUjPebvndMAR9EoVg@mail.gmail.com>
Date:	Wed, 10 Jun 2015 16:03:52 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Sergei Zviagintsev <sergei@...v.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 04/10] Documentation/kdbus: use parentheses uniformly
 in KDBUS_ITEM_FOREACH macro

Hi

On Tue, Jun 9, 2015 at 11:00 PM, Sergei Zviagintsev <sergei@...v.net> wrote:
> Enclose all arguments into parentheses to stay consistent across the
> whole macro.
>
> Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
> ---
>  Documentation/kdbus/kdbus.item.xml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kdbus/kdbus.item.xml b/Documentation/kdbus/kdbus.item.xml
> index b0eeeef995af..ee09dfa443b8 100644
> --- a/Documentation/kdbus/kdbus.item.xml
> +++ b/Documentation/kdbus/kdbus.item.xml
> @@ -72,10 +72,10 @@
>      (typeof(item))((uint8_t *)(item) + KDBUS_ALIGN8((item)->size))

Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks
David

>  #define KDBUS_ITEM_FOREACH(item, head, first)                      \
> -    for (item = (head)->first;                                     \
> +    for ((item) = (head)->first;                                   \
>           ((uint8_t *)(item) < (uint8_t *)(head) + (head)->size) && \
>            ((uint8_t *)(item) >= (uint8_t *)(head));                \
> -         item = KDBUS_ITEM_NEXT(item))
> +         (item) = KDBUS_ITEM_NEXT(item))
>        ]]></programlisting>
>      </refsect2>
>    </refsect1>
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/