linux-kernel - Re: [PATCH v2 07/10] selftests/kdbus: use parentheses in iteration macros uniformly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2015 16:08:22 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Sergei Zviagintsev <sergei@...v.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 07/10] selftests/kdbus: use parentheses in iteration
 macros uniformly

Hi

On Tue, Jun 9, 2015 at 11:00 PM, Sergei Zviagintsev <sergei@...v.net> wrote:
> Enclose all arguments into parentheses in KDBUS_ITEM_FOREACH and
> KDBUS_FOREACH macros to stay consistent across the whole macro.
>
> Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
> ---
>  tools/testing/selftests/kdbus/kdbus-util.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks
David

> diff --git a/tools/testing/selftests/kdbus/kdbus-util.h b/tools/testing/selftests/kdbus/kdbus-util.h
> index df5721ee8f54..d1a0f1b4d0eb 100644
> --- a/tools/testing/selftests/kdbus/kdbus-util.h
> +++ b/tools/testing/selftests/kdbus/kdbus-util.h
> @@ -29,15 +29,15 @@
>  #define KDBUS_ITEM_NEXT(item) \
>         (typeof(item))((uint8_t *)(item) + KDBUS_ALIGN8((item)->size))
>  #define KDBUS_ITEM_FOREACH(item, head, first)                          \
> -       for (item = (head)->first;                                      \
> +       for ((item) = (head)->first;                                    \
>              ((uint8_t *)(item) < (uint8_t *)(head) + (head)->size) &&  \
>                ((uint8_t *)(item) >= (uint8_t *)(head));                \
> -            item = KDBUS_ITEM_NEXT(item))
> +            (item) = KDBUS_ITEM_NEXT(item))
>  #define KDBUS_FOREACH(iter, first, _size)                              \
> -       for (iter = (first);                                            \
> +       for ((iter) = (first);                                          \
>              ((uint8_t *)(iter) < (uint8_t *)(first) + (_size)) &&      \
>                ((uint8_t *)(iter) >= (uint8_t *)(first));               \
> -            iter = (void *)(((uint8_t *)iter) + KDBUS_ALIGN8((iter)->size)))
> +            (iter) = (void *)((uint8_t *)(iter) + KDBUS_ALIGN8((iter)->size)))
>
>  #define _KDBUS_ATTACH_BITS_SET_NR (__builtin_popcountll(_KDBUS_ATTACH_ALL))
>
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/