linux-kernel - Re: [PATCH v2 09/10] samples/kdbus: fix operator precedence issue in KDBUS_ITEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANq1E4QoMf5gSPBtsPccaMWwfOjEjR1gZh7+J3uUqzXTXvGY5w@mail.gmail.com>
Date:	Wed, 10 Jun 2015 16:09:40 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Sergei Zviagintsev <sergei@...v.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 09/10] samples/kdbus: fix operator precedence issue in
 KDBUS_ITEM_NEXT macro

Hi

On Tue, Jun 9, 2015 at 11:00 PM, Sergei Zviagintsev <sergei@...v.net> wrote:
> `item' argument in KDBUS_ITEM_NEXT macro is not enclosed into
> parentheses when the cast operator is applied, which leads to improper
> type conversion if `item' is supplied as a complex expression, e.g.
>
>     KDBUS_ITEM_NEXT(condition ? a : b)
>
> Use parentheses properly to guarantee right precedence.
>
> Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
> ---
>  samples/kdbus/kdbus-api.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks
David

> diff --git a/samples/kdbus/kdbus-api.h b/samples/kdbus/kdbus-api.h
> index 2de4d6a8c51e..fab873b89d97 100644
> --- a/samples/kdbus/kdbus-api.h
> +++ b/samples/kdbus/kdbus-api.h
> @@ -8,7 +8,7 @@
>  #define KDBUS_ITEM_HEADER_SIZE offsetof(struct kdbus_item, data)
>  #define KDBUS_ITEM_SIZE(s) KDBUS_ALIGN8((s) + KDBUS_ITEM_HEADER_SIZE)
>  #define KDBUS_ITEM_NEXT(item) \
> -       (typeof(item))(((uint8_t *)item) + KDBUS_ALIGN8((item)->size))
> +       (typeof(item))((uint8_t *)(item) + KDBUS_ALIGN8((item)->size))
>  #define KDBUS_FOREACH(iter, first, _size)                              \
>         for (iter = (first);                                            \
>              ((uint8_t *)(iter) < (uint8_t *)(first) + (_size)) &&      \
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/