linux-kernel - Re: [PATCH v2 00/10] kdbus: macros fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANq1E4QYn439mkps5D8=wUZV_qk8xR_bn-TRaayk7FY-OHu5hQ@mail.gmail.com>
Date:	Wed, 10 Jun 2015 16:13:49 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Sergei Zviagintsev <sergei@...v.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 00/10] kdbus: macros fixes

Hi

On Tue, Jun 9, 2015 at 10:59 PM, Sergei Zviagintsev <sergei@...v.net> wrote:
> Fix type conversion and style issues in item macros.
>
> First submission was in 2 separate emails:
> https://lkml.kernel.org/g/1433414370-17557-1-git-send-email-sergei@s15v.net
> https://lkml.kernel.org/g/1433414370-17557-2-git-send-email-sergei@s15v.net
>
> Changes in v2:
>
>  - fixed similar type cast issue in KDBUS_ITEMS_END macro
>  - all arguments in iteration macros are enclosed in parentheses,
>    instead of using loop cursor without them
>  - summary phrases and commit messages updated
>  - documentation updates are excluded to their own patches
>  - added fixes for samples/kdbus
>  - added fixes for selftests/kdbus
>
>
> Sergei Zviagintsev (10):
>   kdbus: fix operator precedence issues in item macros
>   kdbus: use parentheses uniformly in KDBUS_ITEMS_FOREACH macro
>   Documentation/kdbus: fix operator precedence issue in KDBUS_ITEM_NEXT
>     macro
>   Documentation/kdbus: use parentheses uniformly in KDBUS_ITEM_FOREACH
>     macro
>   selftests/kdbus: fix trivial style issues
>   selftests/kdbus: fix precedence issues in macros
>   selftests/kdbus: use parentheses in iteration macros uniformly
>   samples/kdbus: add whitespace
>   samples/kdbus: fix operator precedence issue in KDBUS_ITEM_NEXT macro
>   samples/kdbus: use parentheses uniformly in KDBUS_FOREACH macro

Next time, please merge most of these changes to reduce the number of
patches and review-overhead. But looks all good to me, much
appreciated.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/