linux-kernel - Re: [PATCH] firmware: ACPI iBFT firmware support on EFI machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2015 10:25:42 -0400
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Hannes Reinecke <hare@...e.de>
Cc:	Mike Christie <michaelc@...wisc.edu>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	Konrad Rzeszutek Wilk <konrad@...nel.org>,
	open-iscsi@...glegroups.com
Subject: Re: [PATCH] firmware: ACPI iBFT firmware support on EFI machines

On Wed, Jun 10, 2015 at 2:32 AM, Hannes Reinecke <hare@...e.de> wrote:
> The iBFT firmware tables can also be specified via ACPI tables
> when using EFI firmware. The 'iscsi_ibft_find' module is only
> for legacy X86 BIOS, so it needs to be skipped for all other
> architectures.

If this is only valid for X86,  you probably want to add a dependency
on X86.  There are other architectures that use ACPI, notable ia64 and
arm64 in the not distant future.

josh

> Signed-off-by: Hannes Reinecke <hare@...e.de>
> ---
>  drivers/firmware/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 6517132..79204b2 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -124,7 +124,7 @@ config ISCSI_IBFT_FIND
>  config ISCSI_IBFT
>         tristate "iSCSI Boot Firmware Table Attributes module"
>         select ISCSI_BOOT_SYSFS
> -       depends on ISCSI_IBFT_FIND && SCSI && SCSI_LOWLEVEL
> +       depends on (ISCSI_IBFT_FIND || ACPI) && SCSI && SCSI_LOWLEVEL
>         default n
>         help
>           This option enables support for detection and exposing of iSCSI
> --
> 1.8.5.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/