linux-kernel - RE: [PATCH v5] Fix the resolution issue in ChromeOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2015 22:41:26 +0800
From:	"Hn Chen" <hn.chen@...dahitech.com>
To:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
Cc:	<linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5] Fix the resolution issue in ChromeOS

Hi, Dmitry, 

Thanks for your suggestion !

> Thank you for making changes, I have some more comments. By the way, have you tried running scripts/checkpatch.pl over your patch? 
> It often picks up some common issues.
I did the check before I submit the patch every time. Below is the way what I did, is it lack of some parameters ?
./scripts/checkpatch.pl -f driver/input/touchscreen/wdt87xx_i2c.c
Or do I check the wrong file ?  

> Why do you need to disable IRQ here just ti enable it again in probe()?
Just in case to prevent the IRQ triggered and the input device is not ready.
After you remind me to create the input device first and then request irq, 
I think they (disable IRQ in request & enable IRQ in probe) can be just removed from codes.

Hn.chen 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/