linux-kernel - Re: [PATCH] Input: goodix - do not explicitly set evbits in input device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2015 17:08:39 +0200
From:	Bastien Nocera <hadess@...ess.net>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Irina Tirdea <irina.tirdea@...el.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: goodix - do not explicitly set evbits in input
 device

On Wed, 2015-06-10 at 10:39 -0400, Benjamin Tissoires wrote:
> On Jun 10 2015 or thereabouts, Bastien Nocera wrote:
> > On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote:
> > > input_mt_init_slots() will do that for us.
> > 
> > I'm guessing you know what you're doing here, but I couldn't find 
> > where
> > the EV_SYN bit would have been set in the input_mt_init_slots() 
> > call
> > chain.
> 
> input_register_device() sets EV_SYN bit for us (it is a mandatory 
> field
> for input).
<snip>
> 
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

OK, thanks for the explanation.

Acked-by: Bastien Nocera <hadess@...ess.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/