linux-kernel - RE: [PATCH v2] acpi: update ACPI tables to match TCG ACPI specification.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F31A6@ORSMSX112.amr.corp.intel.com>
Date:	Wed, 10 Jun 2015 15:34:28 +0000
From:	"Moore, Robert" <robert.moore@...el.com>
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>
CC:	"peterhuewe@....de" <peterhuewe@....de>,
	Len Brown <lenb@...nel.org>, "Zheng, Lv" <lv.zheng@...el.com>,
	ACPI <linux-acpi@...r.kernel.org>,
	"open list:ACPI COMPONENT AR..." <devel@...ica.org>,
	open list <linux-kernel@...r.kernel.org>,
	"Box, David E" <david.e.box@...el.com>
Subject: RE: [PATCH v2] acpi: update ACPI tables to match TCG ACPI
 specification.

We may do a quick update for the TCPA and TPM2 tables; but having two different ACPI tables with the same signature (TCPA client and TCPA server) throws a bit of a monkey wrench into some of the ACPICA stuff. Not only do we support ACPI tables in the headers, but we also support them in the table disassembler and the table template generator.

> -----Original Message-----
> From: Jarkko Sakkinen [mailto:jarkko.sakkinen@...ux.intel.com]
> Sent: Wednesday, June 10, 2015 5:13 AM
> To: Rafael J. Wysocki; Moore, Robert
> Cc: peterhuewe@....de; Len Brown; Zheng, Lv; ACPI; open list:ACPI
> COMPONENT AR...; open list
> Subject: Re: [PATCH v2] acpi: update ACPI tables to match TCG ACPI
> specification.
> 
> OK, thank you guys. We'll start to use it as soon as the changes get to
> the kernel tree from ACPICA.
> 
> /Jarkko
> 
> On 06/10/2015 01:15 AM, Rafael J. Wysocki wrote:
> > On Tuesday, June 09, 2015 07:25:25 PM Jarkko Sakkinen wrote:
> >> Updated struct acpi_table_tpm2 and struct acpi_table_tcpa to match
> >> the TCG ACPI specification.
> >>
> >> v2:
> >>
> >> - Do not remove struct acpi_tpm2_control
> >>
> >> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > Bob, I'm assuming that we'll be routing this one through upstream
> ACPICA.
> >
> > If that's not the case and I should apply it directly, please let me
> know.
> >
> >
> >> ---
> >>   include/acpi/actbl2.h |  5 ++---
> >>   include/acpi/actbl3.h | 17 +++++++++++++----
> >>   2 files changed, 15 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h index
> >> cafdeb5..2f2b8a6 100644
> >> --- a/include/acpi/actbl2.h
> >> +++ b/include/acpi/actbl2.h
> >> @@ -1071,14 +1071,13 @@ enum acpi_spmi_interface_types {
> >>    * TCPA - Trusted Computing Platform Alliance table
> >>    *        Version 1
> >>    *
> >> - * Conforms to "TCG PC Specific Implementation Specification",
> >> - * Version 1.1, August 18, 2003
> >> + * Conforms to "TCG ACPI Specification for Family 1.2 and 2.0" 19
> >> + December 2014
> >>    *
> >>
> >> *********************************************************************
> >> *********/
> >>
> >>   struct acpi_table_tcpa {
> >>   	struct acpi_table_header header;	/* Common ACPI table header */
> >> -	u16 reserved;
> >> +	u16 platform_class;	/* 0 for client and 1 for server platforms.
> */
> >>   	u32 max_log_length;	/* Maximum length for the event log area */
> >>   	u64 log_address;	/* Address of the event log area */
> >>   };
> >> diff --git a/include/acpi/actbl3.h b/include/acpi/actbl3.h index
> >> 440ca81..8dd625c 100644
> >> --- a/include/acpi/actbl3.h
> >> +++ b/include/acpi/actbl3.h
> >> @@ -688,15 +688,24 @@ enum acpi_rasf_status {
> >>    * TPM2 - Trusted Platform Module (TPM) 2.0 Hardware Interface Table
> >>    *        Version 3
> >>    *
> >> - * Conforms to "TPM 2.0 Hardware Interface Table (TPM2)" 29 November
> >> 2011
> >> + * Conforms to "TCG ACPI Specification for Family 1.2 and 2.0" 19
> >> + December 2014
> >>    *
> >>
> >> *********************************************************************
> >> *********/
> >>
> >> +/* How to notify that there is a command available for processing.
> >> +*/
> >> +
> >> +enum acpi_tpm2_start_method {
> >> +	ACPI_TPM2_SM_ACPI = 2,
> >> +	ACPI_TPM2_SM_CRB = 7,
> >> +	ACPI_TPM2_SM_CRB_AND_ACPI = 8,
> >> +};
> >> +
> >>   struct acpi_table_tpm2 {
> >>   	struct acpi_table_header header;	/* Common ACPI table header */
> >> -	u32 flags;
> >> -	u64 control_address;
> >> -	u32 start_method;
> >> +	u16 platform_class;	/* 0 for client and 1 for server platforms
> */
> >> +	u16 reserved;
> >> +	u64 control_address;	/* Physical address of the control area */
> >> +	u32 start_method;	/* Method to notify to start processing */
> >>   };
> >>
> >>   /* Control area structure (not part of table, pointed to by
> >> control_address) */
> >>