linux-kernel - RE: [PATCH] regmap: add virtual PMIC IPC bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02E7334B1630744CBDC55DA85862258349310BBD@ORSMSX102.amr.corp.intel.com>
Date:	Wed, 10 Jun 2015 15:51:06 +0000
From:	"Yang, Fei" <fei.yang@...el.com>
To:	"Zha, Qipeng" <qipeng.zha@...el.com>,
	Mark Brown <broonie@...nel.org>,
	"Pan, Jacob jun" <jacob.jun.pan@...el.com>,
	"Ortiz, Samuel" <samuel.ortiz@...el.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Zhong, Huiquan" <huiquan.zhong@...el.com>,
	"Chen, Jason CJ" <jason.cj.chen@...el.com>,
	"Zheng, Qi" <qi.zheng@...el.com>
Subject: RE: [PATCH] regmap: add virtual PMIC IPC bus support

> > >Why is this being added to the regmap core rather than being 
> > >implemented in using the reg_write() and reg_read() callbacks in the 
> > >core driver for the PMIC?

> > Thanks. I don't receive this message before in eamil.
> > Current regmap only support register access  using several bus:  i2c, spi, ac97 ...
> > But register access for intel pmic are done by hardware ipc, so we add 
> > such support in regmap core, To make pmic subdevice drivers can use generic regmap r/w API to access registers.

> That doesn't really address my concern - we already have the reg_read() and reg_write() interface so devices can use
> regmap without a bus in the core.  The question is if this is something that's going to be used by many devices so there's
> code to share or if it's something that's only going to be used by this PMIC in which case keeping it in the driver should be easier.

The IPC code is actually independent of PMIC, it will evolve together with the PMC firmware instead of PMIC. Maintaining the IPC
code inside a PMIC driver would be weird because PMIC doesn't really know/care anything about IPC.
In other words, the same PMIC driver could run on different platforms with either i2c or IPC access without knowing which mechanism is
running underneath.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/