linux-kernel - Re: [PATCH v5 12/21] libnvdimm: namespace indices: read and validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2015 08:54:32 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Christoph Hellwig <hch@....de>
Cc:	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	Jens Axboe <axboe@...nel.dk>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Neil Brown <neilb@...e.de>,
	Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Linux ACPI <linux-acpi@...r.kernel.org>,
	jmoyer <jmoyer@...hat.com>, linux-api@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v5 12/21] libnvdimm: namespace indices: read and validate

On Mon, Jun 8, 2015 at 11:39 PM, Christoph Hellwig <hch@....de> wrote:
>> +#include <asm-generic/io-64-nonatomic-lo-hi.h>
>> +
>> +#ifndef __io_virt
>> +#define __io_virt(x) ((void __force *) (x))
>> +#endif
>
> NAK. driver code mus never include asm-generic headers directly,
> and __io_virt isn't something that's up to a driver to redefine either.
>
> I think we really need the memremap series in first before trying to
> do the things done in this patch.

I was abusing read[wlq] and write[wlq].  All this patch needs is a
conversion to use __leXXto_cpu and __cpu_to_leXX helpers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/