linux-kernel - Re: [PATCH 3/3] EDAC, mce_amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55786632.9020701@amd.com>
Date:	Wed, 10 Jun 2015 11:30:42 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	linux-edac <linux-edac@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] EDAC, mce_amd_inj: Set MISCV on injection

On 6/10/2015 10:33 AM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
>
> When during injection we populate MCi_MISC by writing into misc, we need
> to set the MiscV bit in the corresponding MCi_STATUS register which
> denotes that there's valid info in the MCi_MISC register.
>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> ---
>   drivers/edac/mce_amd_inj.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c
> index 5001d166f54f..021f256b7f11 100644
> --- a/drivers/edac/mce_amd_inj.c
> +++ b/drivers/edac/mce_amd_inj.c
> @@ -248,6 +248,9 @@ static void do_inject(void)
>   	unsigned int cpu = i_mce.extcpu;
>   	u8 b = i_mce.bank;
>   
> +	if (i_mce.misc)
> +		i_mce.status |= MCI_STATUS_MISCV;
> +
>   	if (inj_type == SW_INJ) {
>   		amd_decode_mce(NULL, 0, &i_mce);
>   		return;


Thanks for the catch here and on Patch 2:)

Looks good to me. So you can slap a <Reviewed-by>  on them if needed..

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/