linux-kernel - Re: [PATCH] USB SERIAL: option.c: add 2020:4000 IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150610170202.GD1295@localhost>
Date:	Wed, 10 Jun 2015 19:02:02 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Claudio Cappelli <claudio.cappelli.linux@...il.com>
Cc:	linux-usb@...r.kernel.org, Johan Hovold <johan@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB SERIAL: option.c: add 2020:4000 IDs

On Wed, Jun 10, 2015 at 06:08:09PM +0200, Claudio Cappelli wrote:
> From: Claudio Cappelli <claudio.cappelli.linux@...il.com>
> 
> Add device Olivetti Olicard 300 (Network Connect: MT6225) - IDs 2020:4000.
> 
> Signed-off-by: Claudio Cappelli <claudio.cappelli.linux@...il.com>
> Suggested-by: Lars Melin <larsm17@...il.com>
> 
> ---
> 
> drivers/usb/serial/option.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> 
> --- linux/drivers/usb/serial/option.c.orig      2015-06-10 10:42:43.000000000 +0200
> +++ linux/drivers/usb/serial/option.c   2015-06-10 10:53:06.825265579 +0200
> @@ -1765,6 +1765,7 @@ static const struct usb_device_id option
>         { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x00, 0x00) },
>         { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */
>         { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */
> +       { USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) },                /* OLICARD300 - MT6225 */
>         { USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
>         { USB_DEVICE(VIATELECOM_VENDOR_ID, VIATELECOM_PRODUCT_CDS7) },
>         { } /* Terminating entry */

You should run checkpatch.pl on your patch before submitting. It would
have let you know that there are some white space issues (leading
spaces). You can ignore the long-line-warning in this case.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/