linux-kernel - Re: [PATCH v2] [x86/kvm] emulate.c: Fix comppilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACK8Z6FSK4Bn5M2trb457Jt3w17GBU78-PuaSEeP0zUeYShfzw@mail.gmail.com>
Date:	Wed, 10 Jun 2015 10:04:11 -0700
From:	Rajat Jain <rajatja@...gle.com>
To:	Bandan Das <bsd@...hat.com>
Cc:	Gleb Natapov <gleb@...nel.org>,
	Paolo Bonzini <pbonzini@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Rajat Jain <rajatxjain@...il.com>
Subject: Re: [PATCH v2] [x86/kvm] emulate.c: Fix comppilation warning

Hello Bandan,

On Tue, Jun 9, 2015 at 6:17 PM, Bandan Das <bsd@...hat.com> wrote:
> Rajat Jain <rajatja@...gle.com> writes:
>
>> Fix the following warning:
>>
>> arch/x86/kvm/emulate.c: In function '__do_insn_fetch_bytes':
>> arch/x86/kvm/emulate.c:814:47: warning: 'linear' may be used uninitialized in this function [-Wmaybe-uninitialized]
>> arch/x86/kvm/emulate.c:793:16: note: 'linear' was declared here
>
> Is this recent gcc behavior ? If yes, please mention that in the commit
> message.

Sorry, I realized that I was using an internal version of gcc. I don't
see the warning with gcc 4.8.2 that comes with ubuntu. So I guess we
can ignore the patch then...

Thanks,

Rajat

>
> Please follow convention for the subject line and fix the typo -
> "KVM: emulate: Fix compilation warning"
>
> Thanks,
> Bandan
>
>
>> Signed-off-by: Rajat Jain <rajatja@...gle.com>
>> Signed-off-by: Rajat Jain <rajatxjain@...il.com>
>> ---
>> v2: Fix the wrong email address.
>>
>>  arch/x86/kvm/emulate.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
>> index 630bcb0..f06e0ca 100644
>> --- a/arch/x86/kvm/emulate.c
>> +++ b/arch/x86/kvm/emulate.c
>> @@ -790,7 +790,7 @@ static int __do_insn_fetch_bytes(struct x86_emulate_ctxt *ctxt, int op_size)
>>  {
>>       int rc;
>>       unsigned size, max_size;
>> -     unsigned long linear;
>> +     unsigned long linear = 0;
>>       int cur_size = ctxt->fetch.end - ctxt->fetch.data;
>>       struct segmented_address addr = { .seg = VCPU_SREG_CS,
>>                                          .ea = ctxt->eip + cur_size };
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/