linux-kernel - Re: [PATCH 1/1 linux-next] staging: rtl8723au: use swap() in WMMOnAssocRsp23a()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wrfjbngnv47q.fsf@carbonite.lan.trained-monkey.org>
Date:	Wed, 10 Jun 2015 13:54:49 -0400
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Julia Lawall <Julia.Lawall@...6.fr>,
	Larry Finger <Larry.Finger@...inger.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 1/1 linux-next] staging: rtl8723au: use swap() in WMMOnAssocRsp23a()

Fabian Frederick <fabf@...net.be> writes:
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/staging/rtl8723au/core/rtw_wlan_util.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)

Please make sure you base your patches off the staging tree, not off
linux-next.

Jes

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
> index 5280338..3c1315fc 100644
> --- a/drivers/staging/rtl8723au/core/rtw_wlan_util.c
> +++ b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
> @@ -573,7 +573,7 @@ void WMMOnAssocRsp23a(struct rtw_adapter *padapter)
>  	inx[0] = 0; inx[1] = 1; inx[2] = 2; inx[3] = 3;
>  
>  	if (pregpriv->wifi_spec == 1) {
> -		u32 j, tmp, change_inx = false;
> +		u32 j, change_inx = false;
>  
>  		/* entry indx: 0->vo, 1->vi, 2->be, 3->bk. */
>  		for (i = 0; i < 4; i++) {
> @@ -589,14 +589,8 @@ void WMMOnAssocRsp23a(struct rtw_adapter *padapter)
>  				}
>  
>  				if (change_inx) {
> -					tmp = edca[i];
> -					edca[i] = edca[j];
> -					edca[j] = tmp;
> -
> -					tmp = inx[i];
> -					inx[i] = inx[j];
> -					inx[j] = tmp;
> -
> +					swap(edca[i], edca[j]);
> +					swap(inx[i], inx[j]);
>  					change_inx = false;
>  				}
>  			}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/