linux-kernel - Re: [PATCH v4 04/25] security/security: Introduce security_settime64() function with timespec64 type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJJ+tjvkDvG-p=u-rA8JLBJENiPRfOZ8Y+OsWq3CtfbFA@mail.gmail.com>
Date:	Wed, 10 Jun 2015 12:30:13 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Baolin Wang <baolin.wang@...aro.org>
Cc:	Serge Hallyn <serge.hallyn@...onical.com>,
	Arnd Bergmann <arnd@...db.de>,
	Greg KH <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	Paul Moore <pmoore@...hat.com>, Takashi Iwai <tiwai@...e.de>,
	Jeffrey Vander Stoep <jeffv@...gle.com>,
	Jeffrey Layton <jlayton@...marydata.com>,
	Stephen Smalley <sds@...ho.nsa.gov>, mark.d.rustad@...el.com,
	linux-security-module <linux-security-module@...r.kernel.org>,
	y2038 Mailman List <y2038@...ts.linaro.org>
Subject: Re: [PATCH v4 04/25] security/security: Introduce security_settime64()
 function with timespec64 type

On Tue, Jun 9, 2015 at 8:14 PM, Baolin Wang <baolin.wang@...aro.org> wrote:
> On 6 June 2015 at 12:27, Baolin Wang <baolin.wang@...aro.org> wrote:
>> On 6 June 2015 at 04:04, Kees Cook <keescook@...omium.org> wrote:
>>> On Mon, Jun 1, 2015 at 4:52 AM, Baolin Wang <baolin.wang@...aro.org>
>>> wrote:
>>> >  include/linux/security.h |   25 ++++++++++++++++++++-----
>>> >  security/commoncap.c     |    2 +-
>>> >  security/security.c      |    2 +-
>>> >  3 files changed, 22 insertions(+), 7 deletions(-)
>>>
>>> We certainly want this in, but this area has been rather radically
>>> refactored recently. Can you rebase this patch against security-next?
>>>
>
> Hi Kees,
>
> I have rebased my patch series, but can not find your refactored code.
> Could you tell me the commit information? Thanks a lot!

It lives in security-next, but you could use linux-next too. This is
what I see on a trivial patch attempt:

checking file include/linux/security.h
Hunk #1 succeeded at 69 with fuzz 1 (offset -6 lines).
Hunk #2 FAILED at 1353.
Hunk #3 FAILED at 1483.
Hunk #4 succeeded at 206 (offset -1584 lines).
Hunk #5 succeeded at 463 (offset -1583 lines).
2 out of 5 hunks FAILED
(Stripping trailing CRs from patch; use --binary to disable.)
checking file security/commoncap.c
Hunk #1 succeeded at 111 (offset -5 lines).
(Stripping trailing CRs from patch; use --binary to disable.)
checking file security/security.c
Hunk #1 succeeded at 213 with fuzz 2 (offset -11 lines).

See http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/
or maybe I misunderstood your question?

Thanks!

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/