linux-kernel - Re: [PATCH 1/1] staging: lustre/lustre/llite: get rid of incorrect type warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Jun 2015 12:11:20 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Tolga Ceylan <tolga.ceylan@...il.com>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Greg Donald <gdonald@...il.com>,
	aybuke ozdemir <aybuke.147@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Tina Johnson <tinajohnson.1234@...il.com>,
	Joe Perches <joe@...ches.com>, HPDD-discuss@...1.01.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: lustre/lustre/llite: get rid of incorrect
 type warning

On Mon, Jun 08, 2015 at 04:01:57PM -0700, Tolga Ceylan wrote:
> In dir.c and llite_lib.c, sparse reports multiple warnings messages
> due to different address spaces. This patch resolves these warnings
> by adding the tag __user for username addresses.
> 
> Signed-off-by: Tolga Ceylan <tolga.ceylan@...il.com>
> ---
>  drivers/staging/lustre/lustre/llite/dir.c       | 78 +++++++++++++------------
>  drivers/staging/lustre/lustre/llite/llite_lib.c |  8 +--
>  2 files changed, 45 insertions(+), 41 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c
> index 4b0de8d..0441c20 100644
> --- a/drivers/staging/lustre/lustre/llite/dir.c
> +++ b/drivers/staging/lustre/lustre/llite/dir.c
> @@ -1258,7 +1258,7 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  		return ll_iocontrol(inode, file, cmd, arg);
>  	case FSFILT_IOC_GETVERSION_OLD:
>  	case FSFILT_IOC_GETVERSION:
> -		return put_user(inode->i_generation, (int *)arg);
> +		return put_user(inode->i_generation, (int __user *)arg);

I have looked at this briefly and I think the correct fix is to make
ll_dir_ioctl() take a void __user *arg instead of an unsigned long arg.

Of course, doing that will introduce more sparse warnings, but those are
correct warnings and we should be warned about them.

Maybe start at the lower level functions like obd_ioctl_getdata() and
obd_ioctl_popdata() and add annotations then work up to the big
functions like ll_dir_ioctl().

We shouldn't be introducing these little casts throughout.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/