linux-kernel - Re: [PATCH 1/1] arm/hw_breakpoint.c: Added #include <linux/kdebug.h> instead of<asm/kdebug.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150611093207.GA15078@arm.com>
Date:	Thu, 11 Jun 2015 10:32:07 +0100
From:	Will Deacon <will.deacon@....com>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"v.narang@...sung.com" <v.narang@...sung.com>
Subject: Re: [PATCH 1/1] arm/hw_breakpoint.c: Added #include <linux/kdebug.h>
 instead of<asm/kdebug.h>

On Thu, Jun 11, 2015 at 10:18:44AM +0100, Maninder Singh wrote:
> This patch fixes below checkpatch.pl warning:
> WARNING: Use #include <linux/kdebug.h> instead of <asm/kdebug.h>
> 
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Reviewed-by: Vaneet Narang <v.narang@...sung.com>
> ---
> arch/arm/kernel/hw_breakpoint.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c
> index dc7d0a9..86eef81 100644
> --- a/arch/arm/kernel/hw_breakpoint.c
> +++ b/arch/arm/kernel/hw_breakpoint.c
> @@ -35,7 +35,7 @@
> #include <asm/cputype.h>
> #include <asm/current.h>
> #include <asm/hw_breakpoint.h>
> -#include <asm/kdebug.h>
> +#include <linux/kdebug.h>
> #include <asm/traps.h>
>  /* Breakpoint currently in use for each BRP. */

afaict, we don't even need the header so we can just drop the #include
altogether. Same for arm64.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/