linux-kernel - Re: [PATCH] Removed unnecessary bool comparisons in r8192U

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150611104431.GA45115@ubuntu>
Date:	Thu, 11 Jun 2015 10:44:42 +0000
From:	"Harisangam, Sharvari (S.)" <sharisan@...teon.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lorenzo Stoakes <lstoakes@...il.com>,
	Cristina Opriceana <cristina.opriceana@...il.com>,
	"Greg Donald" <gdonald@...il.com>,
	Karthik Nayak <karthik.188@...il.com>,
	"Vaishali Thakkar" <vthakkar1994@...il.com>
CC:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Removed unnecessary bool comparisons in r8192U_dm.c

On Thu, Jun 11, 2015 at 02:46:21PM +0530, Harisangam Sharvari wrote:
> From: Harisangam Sharvari <sharisan@...teon.com>
> 
> This patch was detected with the help of coccinelle tool. 
> The unnecessary comparisons of bool variables are removed.
> 
> Signed-off-by: Harisangam Sharvari <sharisan@...teon.com>
> ---
>  drivers/staging/rtl8192u/r8192U_dm.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> index 12dd19e..cf3537a 100644
> --- a/drivers/staging/rtl8192u/r8192U_dm.c
> +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> @@ -563,7 +563,7 @@ static void dm_TXPowerTrackingCallback_TSSI(struct net_device *dev)
>  					break;
>  				}
>  			}
> -			if (viviflag == true) {
> +			if (viviflag) {
>  				write_nic_byte(dev, 0x1ba, 0);
>  				viviflag = false;
>  				RT_TRACE(COMP_POWER_TRACKING, "we filtered the data\n");
> @@ -766,7 +766,7 @@ void dm_txpower_trackingcallback(struct work_struct *work)
>  	struct r8192_priv *priv = container_of(dwork, struct r8192_priv, txpower_tracking_wq);
>  	struct net_device *dev = priv->ieee80211->dev;
>  
> -	if (priv->bDcut == true)
> +	if (priv->bDcut)
>  		dm_TXPowerTrackingCallback_TSSI(dev);
>  	else
>  		dm_TXPowerTrackingCallback_ThermalMeter(dev);
> @@ -1301,7 +1301,7 @@ void dm_initialize_txpower_tracking(struct net_device *dev)
>  {
>  	struct r8192_priv *priv = ieee80211_priv(dev);
>  
> -	if (priv->bDcut == true)
> +	if (priv->bDcut)
>  		dm_InitializeTXPowerTracking_TSSI(dev);
>  	else
>  		dm_InitializeTXPowerTracking_ThermalMeter(dev);
> @@ -1357,7 +1357,7 @@ static void dm_check_txpower_tracking(struct net_device *dev)
>  #ifdef RTL8190P
>  	dm_CheckTXPowerTracking_TSSI(dev);
>  #else
> -	if (priv->bDcut == true)
> +	if (priv->bDcut)
>  		dm_CheckTXPowerTracking_TSSI(dev);
>  	else
>  		dm_CheckTXPowerTracking_ThermalMeter(dev);
> @@ -1467,7 +1467,7 @@ void dm_cck_txpower_adjust(struct net_device *dev, bool binch14)
>  {	/*  dm_CCKTxPowerAdjust */
>  	struct r8192_priv *priv = ieee80211_priv(dev);
>  
> -	if (priv->bDcut == true)
> +	if (priv->bDcut)
>  		dm_CCKTxPowerAdjust_TSSI(dev, binch14);
>  	else
>  		dm_CCKTxPowerAdjust_ThermalMeter(dev, binch14);
> @@ -3062,7 +3062,7 @@ static void dm_dynamic_txpower(struct net_device *dev)
>  			priv->bDynamicTxLowPower = false;
>  		} else {
>  			/* high power state check */
> -			if (priv->undecorated_smoothed_pwdb < txlowpower_threshold && priv->bDynamicTxHighPower == true)
> +			if (priv->undecorated_smoothed_pwdb < txlowpower_threshold && priv->bDynamicTxHighPower)
>  				priv->bDynamicTxHighPower = false;
>  
>  			/* low power state check */
> -- 
> 1.7.9.5

I found that there are some errors in patch submission. Please discard this patch.
I will send the new patch.

Thanks,
Harisangam Sharvari

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/