linux-kernel - Re: [PATCH 1/1] i2c: at91: fix code checker warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150611121608.GW25800@odux.rfo.atmel.com>
Date:	Thu, 11 Jun 2015 14:16:08 +0200
From:	Ludovic Desroches <ludovic.desroches@...el.com>
To:	Cyrille Pitchen <cyrille.pitchen@...el.com>
CC:	<ludovic.desroches@...el.com>, <wsa@...-dreams.de>,
	<linux-i2c@...r.kernel.org>, <nicolas.ferre@...el.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/1] i2c: at91: fix code checker warnings

On Thu, Jun 11, 2015 at 11:16:32AM +0200, Cyrille Pitchen wrote:
> buf_len is a size_t, so unsigned but was tested with '<= 0'.
> 
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@...el.com>

Acked-by: Ludovic Desroches <ludovic.desroches@...el.com>

Thanks

> ---
>  drivers/i2c/busses/i2c-at91.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index 0d2dc7d..967c0cb 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
> @@ -232,7 +232,7 @@ static void at91_twi_dma_cleanup(struct at91_twi_dev *dev)
>  
>  static void at91_twi_write_next_byte(struct at91_twi_dev *dev)
>  {
> -	if (dev->buf_len <= 0)
> +	if (!dev->buf_len)
>  		return;
>  
>  	/* 8bit write works with and without FIFO */
> @@ -275,7 +275,7 @@ static void at91_twi_write_data_dma(struct at91_twi_dev *dev)
>  	struct dma_chan *chan_tx = dma->chan_tx;
>  	unsigned int sg_len = 1;
>  
> -	if (dev->buf_len <= 0)
> +	if (!dev->buf_len)
>  		return;
>  
>  	dma->direction = DMA_TO_DEVICE;
> @@ -347,7 +347,7 @@ error:
>  
>  static void at91_twi_read_next_byte(struct at91_twi_dev *dev)
>  {
> -	if (dev->buf_len <= 0)
> +	if (!dev->buf_len)
>  		return;
>  
>  	/* 8bit read works with and without FIFO */
> -- 
> 1.8.2.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/