linux-kernel - Re: [PATCH] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55799DFC.3000304@toshiba.co.jp>
Date:	Thu, 11 Jun 2015 23:41:00 +0900
From:	KOBAYASHI Yoshitake <yoshitake.kobayashi@...hiba.co.jp>
To:	Richard Weinberger <richard.weinberger@...il.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND)

On 2015/06/10 16:50, Richard Weinberger wrote:
> On Wed, Jun 10, 2015 at 9:08 AM, KOBAYASHI Yoshitake
> <yoshitake.kobayashi@...hiba.co.jp> wrote:
>> This patch enables support for Toshiba BENAND.
>> Toshiba BENAND is a SLC NAND solution that automatically generates ECC
>> inside NAND chip. Newer generation SLC NAND devices of today need multi-bit
>> hardware ECC by NAND controller in SoC. BENAND solution is ECC free,
>> has high performance and backward compatibility in NAND chip trend.
>
> Do you have performance numbers?
> How fast is it compared to a decent HW ECC engine?

Comparing with 24nm SLC NAND, BENAND is few percent faster in write and
more than 5 percent faster in read. But the result depends on usecase
and compared device. I will delete the last sentence.

> Did you see my On-Die ECC series and Brian's comments on it?
> https://lkml.org/lkml/2015/3/25/310
> I suspect some of his comments will apply to you as well.

Thanks for the suggestion.
I would like to post the current driver first to make it open, then
consider how to apply his comments. Because I made a big mistake.

-- <snip> --
>> +obj-$(CONFIG_MTD_NAND_BENAND)  += nand_benand.o
>
> nand_benand.c is not part of this patch.
> Forgot a git add? :-)

Oh!.. I will repost it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/