linux-kernel - Re: [RFT PATCH] dmaengine: Fix choppy sound because of unimplemented resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Jun 2015 18:23:43 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Vinod Koul <vinod.koul@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	gabriel@...een.is, Marek Szyprowski <m.szyprowski@...sung.com>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	stable@...r.kernel.org
Subject: Re: [RFT PATCH] dmaengine: Fix choppy sound because of unimplemented
 resume


On Wed, Jun 10, 2015 at 05:17:07PM +0900, Krzysztof Kozlowski wrote:
> Some drivers implement only pause operation (no resuming). Example is
> pl330 where pause is needed for getting residuum. pl330 does not support
> resume operation, transfer must be stopped after pause.
> 
> However for slaves this is exposed always as "pause and resume" which
> introduces subtle errors on Odroid U3 board (Exynos4412 with pl330).
> After adding pause function to pl330 driver the audio playback
> (utilizing DMA) gets choppy after some time (approximately 24 hours).
> 
> Fix this by exposing "cmd_pause" if and only if pause and resume are
> implemented.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Reported-by: gabriel@...een.is
> Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Cc: <stable@...r.kernel.org>
> Fixes: 88987d2c7534 ("dmaengine: pl330: add DMA_PAUSE feature")

That looks reasonable.

Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

Thanks! (and sorry for that)
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)