linux-kernel - Re: [PATCH 1/1 linux-next] Input: cyttsp4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Jun 2015 13:08:44 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Julia Lawall <Julia.Lawall@...6.fr>,
	Ferruh Yigit <fery@...ress.com>, linux-input@...r.kernel.org
Subject: Re: [PATCH 1/1 linux-next] Input: cyttsp4 - use swap() in
 cyttsp4_get_touch()

On Wed, Jun 10, 2015 at 06:31:43PM +0200, Fabian Frederick wrote:
> Use kernel.h macro definition.
> 
> Thanks to Julia Lawall for Coccinelle scripting support.
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Applied, thank you.

> ---
>  drivers/input/touchscreen/cyttsp4_core.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/cyttsp4_core.c b/drivers/input/touchscreen/cyttsp4_core.c
> index 568a3d3..5ed3105 100644
> --- a/drivers/input/touchscreen/cyttsp4_core.c
> +++ b/drivers/input/touchscreen/cyttsp4_core.c
> @@ -775,7 +775,6 @@ static void cyttsp4_get_touch(struct cyttsp4_mt_data *md,
>  	struct device *dev = &md->input->dev;
>  	struct cyttsp4_sysinfo *si = md->si;
>  	enum cyttsp4_tch_abs abs;
> -	int tmp;
>  	bool flipped;
>  
>  	for (abs = CY_TCH_X; abs < CY_TCH_NUM_ABS; abs++) {
> @@ -790,9 +789,7 @@ static void cyttsp4_get_touch(struct cyttsp4_mt_data *md,
>  	}
>  
>  	if (md->pdata->flags & CY_FLAG_FLIP) {
> -		tmp = touch->abs[CY_TCH_X];
> -		touch->abs[CY_TCH_X] = touch->abs[CY_TCH_Y];
> -		touch->abs[CY_TCH_Y] = tmp;
> +		swap(touch->abs[CY_TCH_X], touch->abs[CY_TCH_Y]);
>  		flipped = true;
>  	} else
>  		flipped = false;
> -- 
> 2.4.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/