linux-kernel - Re: [PATCH] block: pmem: Add dependency on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <557A0386.2000307@kernel.dk>
Date:	Thu, 11 Jun 2015 15:54:14 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Richard Weinberger <richard@....at>,
	Ross Zwisler <ross.zwisler@...ux.intel.com>
CC:	dan.j.williams@...el.com, mingo@...nel.org, willy@...ux.intel.com,
	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...com>,
	Christoph Hellwig <hch@...radead.org>,
	Borislav Petkov <bp@...e.de>, toshi.kani@...com
Subject: Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM

On 06/11/2015 03:53 PM, Richard Weinberger wrote:
> Am 31.05.2015 um 23:12 schrieb Richard Weinberger:
>> Am 04.05.2015 um 22:00 schrieb Ross Zwisler:
>>> On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote:
>>>> Not all architectures have io memory.
>>>>
>>>> Fixes:
>>>> drivers/block/pmem.c: In function ‘pmem_alloc’:
>>>> drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>>>>    pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>>>>    ^
>>>> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default]
>>>>    pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>>>>                    ^
>>>> drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>>>>    iounmap(pmem->virt_addr);
>>>>    ^
>>>>
>>>> Signed-off-by: Richard Weinberger <richard@....at>
>>>> ---
>>>>   drivers/block/Kconfig | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
>>>> index eb1fed5..3ccef9e 100644
>>>> --- a/drivers/block/Kconfig
>>>> +++ b/drivers/block/Kconfig
>>>> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX
>>>>
>>>>   config BLK_DEV_PMEM
>>>>   	tristate "Persistent memory block device support"
>>>> +	depends on HAS_IOMEM
>>>>   	help
>>>>   	  Saying Y here will allow you to use a contiguous range of reserved
>>>>   	  memory as one or more persistent block devices.
>>>
>>> Reviewed-by: Ross Zwisler <ross.zwisler@...ux.intel.com>
>>
>> Ping?
>
> Can someone please pickup this trivial patch?

I'll fold it in.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/