linux-kernel - Re: [patch] [patch 2/2 v2] w1: use correct lock on error in w1_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Jun 2015 18:41:33 -0500
From:	David Fries <david@...es.net>
To:	Evgeniy Polyakov <zbr@...emap.net>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Matt Campbell <mattrcampbell@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [patch] [patch 2/2 v2] w1: use correct lock on error in
 w1_seq_show()

On Thu, Jun 11, 2015 at 06:31:00PM +0300, Evgeniy Polyakov wrote:
> Hi
> 
> 04.06.2015, 12:04, "Dan Carpenter" <dan.carpenter@...cle.com>:
> > I noticed there was a problem here because Smatch complained:
> >
> >         drivers/w1/slaves/w1_therm.c:416 w1_seq_show() warn:
> >         inconsistent returns 'mutex:&sl->master->mutex'.
> >           Locked on: line 416
> >           Unlocked on: line 413
> >
> > The problem is that we lock ->mutex but we unlock ->bus_mutex on error.
> > David Fries says that ->bus_mutex is correct and ->mutex is incorrect.
> >
> > Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm')
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> Looks good to me, Greg please pull this serie into your tree, if you hadn't yet.
> Am I right that this is a stable tree material too?

I would expect the answer to be no.  This is a fix to a new feature
that is in gregkh/char-misc but not yet in Linus's tree.

-- 
David Fries <david@...es.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/