linux-kernel - Re: [PATCH 2/2] scatterlist: cleanup sg_chain() and sg_unmark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150611073107.GD1905@lst.de>
Date:	Thu, 11 Jun 2015 09:31:07 +0200
From:	Christoph Hellwig <hch@....de>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Dan Williams <dan.j.williams@...el.com>, axboe@...nel.dk,
	Vinod Koul <vinod.koul@...el.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	hch@....de, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] scatterlist: cleanup sg_chain() and sg_unmark_end()

On Wed, Jun 10, 2015 at 01:38:04PM +0800, Herbert Xu wrote:
> On Tue, Jun 09, 2015 at 12:27:15PM -0400, Dan Williams wrote:
> >
> > +#define scatterwalk_sg_chain(prv, num, sgl)	sg_chain(prv, num, sgl)
> > +#define scatterwalk_sg_next(sgl)		sg_next(sgl)
> 
> Why are you reintroducing the scatterwalk_sg_next macro that we
> just removed?
> 
> I also don't understand why this is so urgent that it has to go
> into mainline at this late date.

It allows getting a cleaner slate for the next merge window, which seems
useful on it's own.  The re-addition of scatterwalk_sg_next seems next,
but getting rid of the open-coded sg_chain is useful.

Maybe you can take it through the crypto tree and also kill off the
scatterwalk_sg_chain name as well while we're at it?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/