linux-kernel - Re: [PATCH 2/2] iio: proximity: sx9500: Fix proximity value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150612074046.GB14044@vdogaru>
Date:	Fri, 12 Jun 2015 10:40:47 +0300
From:	Vlad Dogaru <vlad.dogaru@...el.com>
To:	Daniel Baluta <daniel.baluta@...el.com>
Cc:	jic23@...nel.org, pmeerw@...erw.net, tiberiu.a.breana@...el.com,
	knaack.h@....de, lars@...afoo.de, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org
Subject: Re: [PATCH 2/2] iio: proximity: sx9500: Fix proximity value

On Thu, Jun 11, 2015 at 06:49:34PM +0300, Daniel Baluta wrote:
> Because of the ABI confusion proximity value exposed by SX9500
> was inverted.
> 
> Signed-off-by: Daniel Baluta <daniel.baluta@...el.com>

Reviewed-by: Vlad Dogaru <vlad.dogaru@...el.com>

Sorry for causing the confusion, it was the only proximity sensor I had
encountered to date.

> ---
>  drivers/iio/proximity/sx9500.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c
> index 2042e37..01494cd 100644
> --- a/drivers/iio/proximity/sx9500.c
> +++ b/drivers/iio/proximity/sx9500.c
> @@ -281,7 +281,7 @@ static int sx9500_read_prox_data(struct sx9500_data *data,
>  	if (ret < 0)
>  		return ret;
>  
> -	*val = 32767 - (s16)be16_to_cpu(regval);
> +	*val = be16_to_cpu(regval);
>  
>  	return IIO_VAL_INT;
>  }
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/