linux-kernel - Re: [PATCH 6/6] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1434098643.2271.141.camel@x220>
Date:	Fri, 12 Jun 2015 10:44:03 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	jakeo@...rosoft.com
Cc:	gregkh@...uxfoundation.org, kys@...rosoft.com,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	olaf@...fle.de, apw@...onical.com, vkuznets@...hat.com,
	linux-pci@...r.kernel.org, bhelgaas@...gle.com,
	mebersol@...rosoft.com, haiyangz@...rosoft.com
Subject: Re: [PATCH 6/6] drivers:pci:hv: New paravirtual PCI front-end for
 Hyper-V VMs

Greg has already asked you to resend. So here follow a few remarks to
take into account for that resend.

On Thu, 2015-06-11 at 16:22 +0000, jakeo@...rosoft.com wrote:

> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
 
> +config HYPERV_VPCI
> +        tristate "Hyper-V PCI Frontend"
> +        depends on PCI && X86 && HYPERV
> +        select PCI_HV

That symbol doesn't exist and is not added in this series, right? If so,
scripts/checkkconsymbols.py could have told you that.

> +        default y

Are you sure?

> +        help
> +          The PCI device frontend driver allows the kernel to import arbitrary
> +          PCI devices from a PCI backend to support PCI driver domains.

> --- /dev/null
> +++ b/drivers/pci/host/hv_pcifront.c

> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published
> + * by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
> + * NON INFRINGEMENT.  See the GNU General Public License for more

This states the license is GPL v2.

> +EXPORT_SYMBOL(hv_read_config_block);

> +EXPORT_SYMBOL(hv_write_config_block);

> +EXPORT_SYMBOL(hv_register_block_invalidate);

I couldn't spot any users of these exports. Actually, I couldn't even
spot any users of these three functions. Why were they added?

> +MODULE_LICENSE("GPL");

This states, according to include/linux/module.h, that the license is
GPL v2 or later. So I think either the comment at the top of this file
or the ident used in the MODULE_LICENSE() macro needs to change.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/