linux-kernel - Re: [PATCH v3 1/4] drivers/rtc/pcf8563: Replace deprecated rtc_time_to_tm() and rtc_tm_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OFFC6B610F.4108EED3-ON48257E62.0032A044-48257E62.00330C68@zte.com.cn>
Date:	Fri, 12 Jun 2015 17:17:39 +0800
From:	pang.xunlei@....com.cn
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	Arnd Bergmann <arnd@...db.de>,
	John Stultz <john.stultz@...aro.org>,
	linux-kernel@...r.kernel.org, Xunlei Pang <pang.xunlei@...aro.org>,
	rtc-linux@...glegroups.com, Xunlei Pang <xlpang@....com>
Subject: Re: [PATCH v3 1/4] drivers/rtc/pcf8563: Replace deprecated rtc_time_to_tm() and
 rtc_tm_to_time()

Hi Alexandre,

Alexandre Belloni <alexandre.belloni@...e-electrons.com> wrote 2015-06-12 
PM 04:40:27:
> 
> Re: [PATCH v3 1/4] drivers/rtc/pcf8563: Replace deprecated 
> rtc_time_to_tm() and rtc_tm_to_time()
> 
> Hi Xunlei,
> 
> Just to let you know that your series are usually classified as spam
> when coming from 126.com. This series in particular didn't make it to
> the mailing list.

Seems ok, I can see it in the mailing list now:
https://lkml.org/lkml/2015/6/11/767

Thanks,
-Xunlei

> 
> I'll take it anyway  but you may want to check that your other patches
> are being received by the maintainers.
> 
> On 12/06/2015 at 10:04:09 +0800, Xunlei Pang wrote :
> > From: Xunlei Pang <pang.xunlei@...aro.org>
> > 
> > pcf8563_rtc_set_alarm() uses deprecated rtc_tm_to_time()
> > and rtc_time_to_tm(), which will overflow in year 2106
> > on 32-bit machines.
> > 
> > This patch solves this by:
> >  - Replacing rtc_time_to_tm() with rtc_time64_to_tm()
> >  - Replacing rtc_tm_to_time() with rtc_tm_to_time64()
> > 
> > Acked-by: Arnd Bergmann <arnd@...db.de>
> > Signed-off-by: Xunlei Pang <pang.xunlei@...aro.org>
> > ---
> > v2->v3:
> > no changes.
> > 
> >  drivers/rtc/rtc-pcf8563.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
> > index 0ba7e59..5f87f84 100644
> > --- a/drivers/rtc/rtc-pcf8563.c
> > +++ b/drivers/rtc/rtc-pcf8563.c
> > @@ -363,13 +363,13 @@ static int pcf8563_rtc_set_alarm(struct 
> device *dev, struct rtc_wkalrm *tm)
> >     struct i2c_client *client = to_i2c_client(dev);
> >     unsigned char buf[4];
> >     int err;
> > -   unsigned long alarm_time;
> > 
> >     /* The alarm has no seconds, round up to nearest minute */
> >     if (tm->time.tm_sec) {
> > -      rtc_tm_to_time(&tm->time, &alarm_time);
> > -      alarm_time += 60-tm->time.tm_sec;
> > -      rtc_time_to_tm(alarm_time, &tm->time);
> > +      time64_t alarm_time = rtc_tm_to_time64(&tm->time);
> > +
> > +      alarm_time += 60 - tm->time.tm_sec;
> > +      rtc_time64_to_tm(alarm_time, &tm->time);
> >     }
> > 
> >     dev_dbg(dev, "%s, min=%d hour=%d wday=%d mday=%d "
> > -- 
> > 1.9.1
> > 
> > 
> 
> -- 
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

--------------------------------------------------------
ZTE Information Security Notice: The information contained in this mail (and any attachment transmitted herewith) is privileged and confidential and is intended for the exclusive use of the addressee(s).  If you are not an intended recipient, any disclosure, reproduction, distribution or other dissemination or use of the information contained is strictly prohibited.  If you have received this mail in error, please delete it and notify us immediately.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/