linux-kernel - Re: [PATCH 01/15] ARM: kill off set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <557AA6A8.2060106@samsung.com>
Date:	Fri, 12 Jun 2015 18:30:16 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Rob Herring <robh@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org
Cc:	linux-kernel@...r.kernel.org, arm@...nel.org,
	Sekhar Nori <nsekhar@...com>,
	Kevin Hilman <khilman@...prootsystems.com>,
	Jason Cooper <jason@...edaemon.net>,
	Andrew Lunn <andrew@...n.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	Hans Ulli Kroll <ulli.kroll@...glemail.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	Imre Kaloz <kaloz@...nwrt.org>,
	Krzysztof Halasa <khalasa@...p.pl>,
	Greg Ungerer <gerg@...inux.org>,
	Roland Stigge <stigge@...com.de>,
	Tony Lindgren <tony@...mide.com>,
	Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Simtec Linux Team <linux@...tec.co.uk>,
	Kukjin Kim <kgene@...nel.org>,
	Wan ZongShun <mcuos.com@...il.com>, linux-omap@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 01/15] ARM: kill off set_irq_flags usage

On 10.06.2015 03:26, Rob Herring wrote:
> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
> 
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROBE -> !IRQ_NOPROBE
> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
> 
> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> and setting IRQ_NOREQUEST already, so there is no need to do this in
> .map() functions and we can simply remove the set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> copy and paste of this code.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> Cc: Russell King <linux@....linux.org.uk>
> Cc: Sekhar Nori <nsekhar@...com>
> Cc: Kevin Hilman <khilman@...prootsystems.com>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> Cc: Gregory Clement <gregory.clement@...e-electrons.com>
> Cc: Hans Ulli Kroll <ulli.kroll@...glemail.com>
> Cc: Shawn Guo <shawn.guo@...aro.org>
> Cc: Sascha Hauer <kernel@...gutronix.de>
> Cc: Imre Kaloz <kaloz@...nwrt.org>
> Cc: Krzysztof Halasa <khalasa@...p.pl>
> Cc: Greg Ungerer <gerg@...inux.org>
> Cc: Roland Stigge <stigge@...com.de>
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Daniel Mack <daniel@...que.org>
> Cc: Haojian Zhuang <haojian.zhuang@...il.com>
> Cc: Robert Jarzmik <robert.jarzmik@...e.fr>
> Cc: Simtec Linux Team <linux@...tec.co.uk>
> Cc: Kukjin Kim <kgene@...nel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Cc: Wan ZongShun <mcuos.com@...il.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-omap@...r.kernel.org
> Cc: linux-samsung-soc@...r.kernel.org
> ---
>  arch/arm/common/it8152.c             |  2 +-
>  arch/arm/common/locomo.c             |  2 +-
>  arch/arm/common/sa1111.c             |  4 ++--
>  arch/arm/mach-davinci/cp_intc.c      |  2 +-
>  arch/arm/mach-dove/irq.c             |  2 +-
>  arch/arm/mach-ebsa110/core.c         |  2 +-
>  arch/arm/mach-footbridge/common.c    |  2 +-
>  arch/arm/mach-footbridge/isa-irq.c   |  8 ++++----
>  arch/arm/mach-gemini/gpio.c          |  2 +-
>  arch/arm/mach-gemini/irq.c           |  2 +-
>  arch/arm/mach-imx/3ds_debugboard.c   |  2 +-
>  arch/arm/mach-imx/mach-mx31ads.c     |  2 +-
>  arch/arm/mach-iop13xx/irq.c          |  2 +-
>  arch/arm/mach-iop32x/irq.c           |  2 +-
>  arch/arm/mach-iop33x/irq.c           |  2 +-
>  arch/arm/mach-ixp4xx/common.c        |  2 +-
>  arch/arm/mach-ks8695/irq.c           |  2 +-
>  arch/arm/mach-lpc32xx/irq.c          |  2 +-
>  arch/arm/mach-netx/generic.c         |  2 +-
>  arch/arm/mach-omap1/fpga.c           |  2 +-
>  arch/arm/mach-omap1/irq.c            |  2 +-
>  arch/arm/mach-pxa/balloon3.c         |  2 +-
>  arch/arm/mach-pxa/irq.c              |  1 -
>  arch/arm/mach-pxa/lpd270.c           |  2 +-
>  arch/arm/mach-pxa/pcm990-baseboard.c |  2 +-
>  arch/arm/mach-pxa/pxa3xx.c           |  2 +-
>  arch/arm/mach-pxa/viper.c            |  2 +-
>  arch/arm/mach-pxa/zeus.c             |  2 +-
>  arch/arm/mach-rpc/ecard.c            |  2 +-
>  arch/arm/mach-rpc/irq.c              | 16 ++++++++--------
>  arch/arm/mach-s3c24xx/bast-irq.c     |  2 +-
>  arch/arm/mach-s3c64xx/common.c       |  2 +-
>  arch/arm/mach-sa1100/irq.c           |  1 -
>  arch/arm/mach-sa1100/neponset.c      |  4 ++--
>  arch/arm/mach-w90x900/irq.c          |  2 +-
>  35 files changed, 45 insertions(+), 47 deletions(-)

For the s3c24xx and s3c64xx it looks fine:
Acked-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/