linux-kernel - Re: [PATCH v2 2/4] rtc/lib: Introduce rtc_tm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OF9B56AD48.E6F20464-ON48257E62.000A21CB-48257E62.000A7C13@zte.com.cn>
Date:	Fri, 12 Jun 2015 09:54:35 +0800
From:	pang.xunlei@....com.cn
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	Arnd Bergmann <arnd@...db.de>,
	John Stultz <john.stultz@...aro.org>,
	linux-kernel@...r.kernel.org, Xunlei Pang <pang.xunlei@...aro.org>,
	rtc-linux@...glegroups.com, Xunlei Pang <xlpang@....com>
Subject: Re: [PATCH v2 2/4] rtc/lib: Introduce rtc_tm_subtract() helper function

Hi Alexandre,

Alexandre Belloni <alexandre.belloni@...e-electrons.com> wrote 2015-06-12 
AM 01:06:19:
> Re: [PATCH v2 2/4] rtc/lib: Introduce rtc_tm_subtract() helper function
> 
> Hi,
> 
> I'm fine with the whole series, I would just rename things a bit:
> 
> On 02/06/2015 at 17:04:20 +0800, Xunlei Pang wrote :
> >  /*
> > + * rtc_tm_subtract - Return the difference in seconds.
> > + */
> > +time64_t rtc_tm_subtract(struct rtc_time *minuend, struct 
> rtc_time *subtrahend)
> > +{
> > +   return rtc_tm_to_time64(minuend) - rtc_tm_to_time64(subtrahend);
> > +}
> > +EXPORT_SYMBOL_GPL(rtc_tm_subtract);
> > +
> > +/*
> >   * Convert rtc_time to ktime
> >   */
> >  ktime_t rtc_tm_to_ktime(struct rtc_time tm)
> > diff --git a/include/linux/rtc.h b/include/linux/rtc.h
> > index 8dcf682..13e4138 100644
> > --- a/include/linux/rtc.h
> > +++ b/include/linux/rtc.h
> > @@ -21,6 +21,8 @@ extern int rtc_year_days(unsigned int day, 
> unsigned int month, unsigned int year
> >  extern int rtc_valid_tm(struct rtc_time *tm);
> >  extern time64_t rtc_tm_to_time64(struct rtc_time *tm);
> >  extern void rtc_time64_to_tm(time64_t time, struct rtc_time *tm);
> > +extern time64_t rtc_tm_subtract(struct rtc_time *minuend,
> > +      struct rtc_time *subtrahend);
> 
> I would use something closer to what is done for timespecs in time.h,
> like:
> 
> static inline time64_t rtc_tm_sub(struct rtc_time *lhs, struct rtc_time 
*rhs)
> {
>    return rtc_tm_to_time64(lhs) - rtc_tm_to_time64(rhs);
> }
> 
> and not modify rtc-lib.c
> 
> Can you make that modification ?

OK, I like this as well, will do.

Thanks,
-Xunlei

--------------------------------------------------------
ZTE Information Security Notice: The information contained in this mail (and any attachment transmitted herewith) is privileged and confidential and is intended for the exclusive use of the addressee(s).  If you are not an intended recipient, any disclosure, reproduction, distribution or other dissemination or use of the information contained is strictly prohibited.  If you have received this mail in error, please delete it and notify us immediately.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/