linux-kernel - Re: [PATCH] staging: sm750fb: fix c99 comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFow2F-pp3E0HfcpzZWipnW2rYhMKmWxhhGkErM9tMjfJ4g0GQ@mail.gmail.com>
Date:	Fri, 12 Jun 2015 03:08:57 -0700
From:	Juston Li <juston.h.li@...il.com>
To:	Konrad Zapalowicz <bergo.torino@...il.com>
Cc:	sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
	gregkh@...uxfoundation.org, linux-fbdev@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: fix c99 comments

On Fri, Jun 12, 2015 at 2:21 AM, Konrad Zapalowicz
<bergo.torino@...il.com> wrote:
>> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
>> index 8b47c1b..b2137c8 100644
>> --- a/drivers/staging/sm750fb/ddk750_chip.c
>> +++ b/drivers/staging/sm750fb/ddk750_chip.c
>> @@ -17,7 +17,7 @@ logical_chip_type_t getChipType(void)
>>       char physicalRev;
>>       logical_chip_type_t chip;
>>
>> -     physicalID = devId750;//either 0x718 or 0x750
>> +     physicalID = devId750; /* either 0x718 or 0x750 /
>
> Does the code compile? I'm worried that the above line will produce
> error as the comment block is not properly closed.
>
>  - konrad

Good catch, can't believe I missed that. I'll fix, actually test compile
this time and resend.

Regards
Juston
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/